refactor(storage): better fs check #7164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Thank you for your contribution! I've reviewed the changes and have some suggestions for improvement. Overall, this is a good improvement that addresses issue #3788 - the change from creating/deleting a test file to using fs.access is more reliable and cleaner.
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
This was referenced Aug 18, 2025
daniel-lxs
approved these changes
Aug 18, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
Thank you @elianiva! This looks good!
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
mrubens
approved these changes
Aug 21, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #3788
Closes: #7173
Roo Code Task Context (Optional)
Description
Currently we're checking if directory is writable by writing a file there and removing it, this could provide false-negative result. This PR changes it to use
fs.accessinstead so it is more consistent between runs.Test Procedure
Tried to run some sessions with the new changes and it seems to be fixed. I also added a new test, though it currently only checks on mocked fs if
fs.accesscall fails and whether or not it should default path / show warning instead of checking with the actual filesystem, not exactly sure what to do here.Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
@elianiva
Important
Refactor directory writability check in
storage.tsusingfs.accessand add tests instorage.spec.ts.getStorageBasePathinstorage.tsto usefs.accessfor checking directory writability instead of creating and deleting a test file.promptForCustomStoragePathinstorage.tsto usefs.accessfor path validation.storage.spec.tsto verify behavior when custom path is writable and when it is not.fs/promisesto simulate different filesystem scenarios.This description was created by
for ba92646. You can customize this summary. It will automatically update as commits are pushed.